Messages in this thread | | | From | Waiman Long <> | Subject | [PATCH v7 0/5] sched: Persistent user requested affinity | Date | Fri, 2 Sep 2022 11:25:51 -0400 |
| |
v6: - Make changes recommended by Peter such as making scratch_mask allocation earlier and using percpu variable to pass information.
v6: - Drop the cpuset patch and make user_cpus_ptr masking applicable to all callers of set_cpus_allowed_ptr(). - Make user_cpus_ptr and cpus_mask update in a single lock critical section to avoid race problems.
v5: - Update patch 3 to handle race with concurrent sched_setaffinity() by rechecking a previously cleared user_cpus_ptr afterward.
The user_cpus_ptr field is added by commit b90ca8badbd1 ("sched: Introduce task_struct::user_cpus_ptr to track requested affinity") which uses it narrowly to allow keeping cpus affinity intact with asymmetric cpu setup.
This patchset extends user_cpus_ptr to store user requested cpus affinity via the sched_setaffinity() API. With that information available, it will enable cpuset and other callers of set_cpus_allowed_ptr() like hotplug to keep cpus afinity as close to what the user wants as possible within the cpu list constraint of the current cpuset. Otherwise some change to the cpuset hierarchy or a hotplug event may reset the cpumask of the tasks in the affected cpusets to the default cpuset value even if those tasks have cpus affinity explicitly set by the users before.
It also means that once sched_setaffinity() is called, user_cpus_ptr will remain allocated until the task exits.
Waiman Long (5): sched: Add __releases annotations to affine_move_task() sched: Use user_cpus_ptr for saving user provided cpumask in sched_setaffinity() sched: Enforce user requested affinity sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race sched: Fix sched_setaffinity() and fork/clone() race
kernel/sched/core.c | 125 +++++++++++++++++++++++++------------------ kernel/sched/sched.h | 10 ++++ 2 files changed, 83 insertions(+), 52 deletions(-)
-- 2.31.1
| |