Messages in this thread | | | Date | Fri, 2 Sep 2022 16:12:58 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 08/10] headers/deps: mm: Split <linux/gfp_types.h> out of <linux/gfp.h> |
| |
On Thu, Sep 01, 2022 at 07:10:09PM -0700, Yury Norov wrote: > On Thu, Sep 01, 2022 at 09:43:13PM +0100, Matthew Wilcox wrote: > > On Wed, Jul 06, 2022 at 10:42:51AM -0700, Yury Norov wrote: > > > From: Ingo Molnar <mingo@kernel.org> > > > > > > This is a much smaller header. > > > > > > Signed-off-by: Ingo Molnar <mingo@kernel.org> > > > Signed-off-by: Yury Norov <yury.norov@gmail.com> > > > --- > > > include/linux/gfp.h | 345 +------------------------------------ > > > include/linux/gfp_types.h | 348 ++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 350 insertions(+), 343 deletions(-) > > > > You move a lot of kernel-doc. Where do you change the rst files? > > Ingo - nowhere. So I did it in the next patch: > > 7343f2b0db4961d ("headers/deps: mm: align MANITAINERS and Docs with new > gfp.h structure")
That's not the right way to do it. Don't merge a patch with bugs and then fix it up in the next patch. Just fix the patch. This is covered in Documentation/process/.
| |