Messages in this thread | | | Date | Fri, 2 Sep 2022 17:56:40 +0300 (EEST) | From | Ilpo Järvinen <> | Subject | Re: [PATCH v2 3/3] tty: serial: use DEFINE_UART_PORT_TX_HELPER_LIMITED() |
| |
On Thu, 1 Sep 2022, Jiri Slaby wrote:
> DEFINE_UART_PORT_TX_HELPER_LIMITED() is a new helper to send characters > to the device. Use it in these drivers. > > mux.c also needs to define tx_done(). But I'm not sure if the driver > really wants to wait for all the characters to dismiss from the HW fifo > at this code point. Hence I marked this as FIXME.
Indeed, it seems odd.
This change looked good to me but I'll give my rev-by only after seeing the next version.
-- i.
> Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: "Pali Rohár" <pali@kernel.org> > Cc: Kevin Cernekee <cernekee@gmail.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang7@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: linux-riscv@lists.infradead.org
| |