lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] scsi: qla2xxx: Fix build error implicit-function-declaration
On Mon, Sep 19, 2022 at 11:08:10AM +0800, Ren Zhijie wrote:
> +#ifdef CONFIG_TRACING
> static void
> qla_trace_init(void)
> {
> @@ -2868,7 +2871,7 @@ qla_trace_uninit(void)
> return;
> trace_array_put(qla_trc_array);
> }
> -
> +#endif

FWIW, the qla2xxx driver uses a different pattern for ifdefs

static void
qla_trace_init(void)
{
#ifdef CONFIG_TRACING
[...]
#endif
}

This avoid to updated the callside with ifdefs.

\
 
 \ /
  Last update: 2022-09-19 09:18    [W:0.144 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site