lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 2/3] dt-bindings: thermal: Convert ls2k to json-schema
From
On 19/09/2022 05:49, Yinbo Zhu wrote:
> Convert the ls2k thermal binding to DT schema format using json-schema
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>

FYI, All your patches were marked as spam, unfortunately.

> ---
> .../bindings/thermal/ls2k-thermal.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml
> new file mode 100644
> index 000000000000..44bc5d4626d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/ls2k-thermal.yaml

Filename based on compatible.

> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/ls2k-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thermal sensors on loongson 2k SoCs
> +
> +maintainers:
> + - zhanghongchen <zhanghongchen@loongson.cn>
> + - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +properties:
> + compatible:
> + const: loongson,2k-thermal
> +
> + reg:
> + maxItems: 1
> +
> + id:
> + const: 0

Why? What is this? No description, no type (is there such standard
property?), no vendor prefix... and always equal to 0?

> +
> + interrupt-parent:
> + maxItems: 1

That's not needed, I think.

> +
> + interrupts:
> + maxItems: 1
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - id
> + - interrupt-parent
> + - interrupts
> + - '#thermal-sensor-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + tsensor: tsensor@1fe01500 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Use names used by other examples.

> + compatible = "loongson,2k-tsensor";
> + reg = <0 0x1fe01500 0 0x30>;
> + id = <0>;
> + interrupt-parent = <&icu>;
> + interrupts = <7>;
> + #thermal-sensor-cells = <1>;
> + };


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-19 09:03    [W:0.280 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site