Messages in this thread | | | Date | Mon, 19 Sep 2022 16:47:47 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH v2] MIPS: Loongson32: Fix PHY-mode being left unspecified |
| |
On Mon, Sep 12, 2022 at 12:10:09AM +0800, Kelvin Cheung wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > commit 0060c8783330 ("net: stmmac: implement support for passive mode > converters via dt") has changed the plat->interface field semantics from > containing the PHY-mode to specifying the MAC-PCS interface mode. Due to > that the loongson32 platform code will leave the phylink interface > uninitialized with the PHY-mode intended by the means of the actual > platform setup. The commit-author most likely has just missed the > arch-specific code to fix. Let's mend the Loongson32 platform code then by > assigning the PHY-mode to the phy_interface field of the STMMAC platform > data. > > Fixes: 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > Tested-by: Keguang Zhang <keguang.zhang@gmail.com> > --- > V1 -> V2: Add my SoB tag > --- > arch/mips/loongson32/common/platform.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
applied to mips-fixes.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |