Messages in this thread | | | Date | Mon, 19 Sep 2022 16:48:31 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH -next] MIPS: SGI-IP27: Fix platform-device leak in bridge_platform_create() |
| |
On Wed, Sep 14, 2022 at 11:29:17AM +0800, Lin Yujun wrote: > In error case in bridge_platform_create after calling > platform_device_add()/platform_device_add_data()/ > platform_device_add_resources(), release the failed > 'pdev' or it will be leak, call platform_device_put() > to fix this problem. > > Besides, 'pdev' is divided into 'pdev_wd' and 'pdev_bd', > use platform_device_unregister() to release sgi_w1 > resources when xtalk-bridge registration fails. > > Fixes: 5dc76a96e95a ("MIPS: PCI: use information from 1-wire PROM for IOC3 detection") > Signed-off-by: Lin Yujun <linyujun809@huawei.com> > --- > arch/mips/sgi-ip27/ip27-xtalk.c | 70 +++++++++++++++++++++++---------- > 1 file changed, 50 insertions(+), 20 deletions(-)
applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |