Messages in this thread | | | From | Eelco Chaudron <> | Subject | Re: [PATCH] openvswitch: Change the return type for vport_ops.send function hook to int | Date | Mon, 19 Sep 2022 15:20:53 +0200 |
| |
On 14 Sep 2022, at 1:07, Nathan Huckleberry wrote:
> All usages of the vport_ops struct have the .send field set to > dev_queue_xmit or internal_dev_recv. Since most usages are set to > dev_queue_xmit, the function hook should match the signature of > dev_queue_xmit. > > The only call to vport_ops->send() is in net/openvswitch/vport.c and it > throws away the return value. > > This mismatched return type breaks forward edge kCFI since the underlying > function definition does not match the function hook definition. > > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > Cc: llvm@lists.linux.dev > Signed-off-by: Nathan Huckleberry <nhuck@google.com>
The changes look good to me.
Acked-by: Eelco Chaudron <echaudro@redhat.com>
| |