Messages in this thread | | | From | Vladimir Panteleev <> | Date | Mon, 19 Sep 2022 13:18:53 +0000 | Subject | Re: [PATCH] watchdog: sp5100_tco: Add "action" module parameter |
| |
Hi Guenter,
On Mon, 19 Sept 2022 at 12:29, Guenter Roeck <linux@roeck-us.net> wrote: > I am not getting into define name editing wars. The define is named as > it is. There is never a good reason to rename it. If I'd accept your > change, someone else might come tomorrow and want it renamed to > "SP5100_WDT_ACTION_POWEROFF" because setting the bit to 1 causes > the system to power off.
Ah, sorry - this is one of my first attempts at contributing to the kernel, and as such I of course fully defer to you. In case I was misunderstood, I was just trying to explain my line of reasoning at the time, which is what I thought you asked for in your previous message. Thank you for the explanation, I was not aware of the high cost of renaming defines.
I will send a V2 if this is all?
Thank you for your time :) Best regards, - Vladimir
| |