lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
From
On 19/09/2022 13:37, Viorel Suman (OSS) wrote:
> From: Viorel Suman <viorel.suman@nxp.com>
>
> Sync defines with the latest available SCFW kit version 1.13.0,
> may be found at the URL below:
>
> https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license
>
> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> ---
> drivers/clk/imx/clk-imx8qm-rsrc.c | 4 +-
> include/dt-bindings/firmware/imx/rsrc.h | 292 ++++++++++++++++--------

Bindings cannot be squashed with driver change.

> 2 files changed, 198 insertions(+), 98 deletions(-)
>
> Changes since v1:
> Two patches squashed into one in order to keep changes bissectable
> and compilable as suggested by Alexander Stein.

That's not the solution. Solution is to make driver behaving correctly,
not squash patches which must not be together.

This is proof of an ABI break, so NAK unless described why it is OK to
break the ABI/users/boards.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-19 13:40    [W:1.096 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site