lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] cgroup: simplify code in cgroup_apply_control
From
Hi,

On 9/17/2022 2:10 PM, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@163.com>
>
> It could directly return 'cgroup_update_dfl_csses' to simplify code.
>
> Signed-off-by: William Dean <williamsukatube@163.com>
> ---
> kernel/cgroup/cgroup.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..1958f8bd93d6 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -3292,11 +3292,7 @@ static int cgroup_apply_control(struct cgroup *cgrp)
> * making the following cgroup_update_dfl_csses() properly update
> * css associations of all tasks in the subtree.
> */
> - ret = cgroup_update_dfl_csses(cgrp);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return cgroup_update_dfl_csses(cgrp);
> }
>
> /**
> --
> 2.25.1
>

LGTM.

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

\
 
 \ /
  Last update: 2022-09-19 12:59    [W:0.032 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site