Messages in this thread | | | Date | Mon, 19 Sep 2022 06:42:22 +0200 | Subject | Re: [PATCH 1/2] serial: 8250: Let drivers request full 16550A feature probing | From | Jiri Slaby <> |
| |
On 17. 09. 22, 12:07, Maciej W. Rozycki wrote: > --- linux-macro.orig/include/linux/serial_core.h > +++ linux-macro/include/linux/serial_core.h > @@ -414,7 +414,7 @@ struct uart_icount { > __u32 buf_overrun; > }; > > -typedef unsigned int __bitwise upf_t; > +typedef __u64 __bitwise upf_t;
Why __u64 and not u64?
> typedef unsigned int __bitwise upstat_t; > > struct uart_port { > @@ -522,6 +522,7 @@ struct uart_port { > #define UPF_FIXED_PORT ((__force upf_t) (1 << 29)) > #define UPF_DEAD ((__force upf_t) (1 << 30)) > #define UPF_IOREMAP ((__force upf_t) (1 << 31)) > +#define UPF_FULL_PROBE ((__force upf_t) (1ULL << 32))
This looks like a perfect time to switch them all to BIT_ULL().
thanks, -- js suse labs
| |