Messages in this thread | | | Subject | Re: [PATCH v5 3/6] iommu/mediatek: Add error path for loop of mm_dts_parse | From | Yong Wu <> | Date | Tue, 20 Sep 2022 09:28:38 +0800 |
| |
On Mon, 2022-09-19 at 16:20 +0200, AngeloGioacchino Del Regno wrote: > Il 19/09/22 11:24, Yong Wu ha scritto: > > The mtk_iommu_mm_dts_parse will parse the smi larbs nodes. if the > > i+1 > > larb is parsed fail, we should put_device for the 0..i larbs. > > If any v6 will be required... you forgot to update the commit > description with > "we should put_device for the i..0 larbs".
oh. Thanks for reviewing so carefully. I will send a quick v6 to fix this.
> > > > > There are two places need to comment: > > 1) The larbid may be not linear mapping, we should loop whole > > the array in the error path. > > 2) I move this line position: "data->larb_imu[id].dev = &plarbdev- > > >dev;" > > before "if (!plarbdev->dev.driver)", That means set > > data->larb_imu[id].dev before the error path. then we don't > > need > > "platform_device_put(plarbdev)" again in probe_defer case. All > > depend > > on "put_device" of the error path in error cases. > > > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with > > the MM TYPE") > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > In any case.... > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com>
Thanks very much:)
> > >
| |