Messages in this thread | | | Date | Sun, 18 Sep 2022 16:59:52 +0200 | Subject | Re: [PATCH] staging: rtl8192e: fix CamelCase variables | From | Philipp Hortmann <> |
| |
On 9/18/22 13:30, Valentin Vidic wrote: > Fix checkpatch warnings for variables: LinkCtrlReg, DeviceID, > RevisionID, IrqLine. > > Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr> > --- > drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 26 ++++++++++----------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c > index 1d992d5c4e17..7a9a24935da9 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c > @@ -16,11 +16,11 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev, > struct r8192_priv *priv = (struct r8192_priv *)rtllib_priv(dev); > > u8 tmp; > - u16 LinkCtrlReg; > + u16 link_ctrl_reg; > > - pcie_capability_read_word(priv->pdev, PCI_EXP_LNKCTL, &LinkCtrlReg); > + pcie_capability_read_word(priv->pdev, PCI_EXP_LNKCTL, &link_ctrl_reg); > > - RT_TRACE(COMP_INIT, "Link Control Register =%x\n", LinkCtrlReg); > + RT_TRACE(COMP_INIT, "Link Control Register =%x\n", link_ctrl_reg); > > pci_read_config_byte(pdev, 0x98, &tmp); > tmp |= BIT4; > @@ -33,28 +33,28 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev, > bool rtl92e_check_adapter(struct pci_dev *pdev, struct net_device *dev) > { > struct r8192_priv *priv = (struct r8192_priv *)rtllib_priv(dev); > - u16 DeviceID; > - u8 RevisionID; > - u16 IrqLine; > + u16 device_id; > + u8 revision_id; > + u16 irq_line; > > - DeviceID = pdev->device; > - RevisionID = pdev->revision; > - pci_read_config_word(pdev, 0x3C, &IrqLine); > + device_id = pdev->device; > + revision_id = pdev->revision; > + pci_read_config_word(pdev, 0x3C, &irq_line); > > priv->card_8192 = priv->ops->nic_type; > > - if (DeviceID == 0x8192) { > - switch (RevisionID) { > + if (device_id == 0x8192) { > + switch (revision_id) { > case HAL_HW_PCI_REVISION_ID_8192PCIE: > dev_info(&pdev->dev, > "Adapter(8192 PCI-E) is found - DeviceID=%x\n", > - DeviceID); > + device_id); > priv->card_8192 = NIC_8192E; > break; > case HAL_HW_PCI_REVISION_ID_8192SE: > dev_info(&pdev->dev, > "Adapter(8192SE) is found - DeviceID=%x\n", > - DeviceID); > + device_id); > priv->card_8192 = NIC_8192SE; > break; > default:
The only thing I do not like so much is that the comment with CamelCase "DeviceID" is not changed.
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
| |