Messages in this thread | | | Date | Thu, 15 Sep 2022 11:04:56 +0200 | Subject | Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt | From | Michal Simek <> |
| |
On 9/15/22 10:44, Krzysztof Kozlowski wrote: > On 14/09/2022 14:15, Mehta, Piyush wrote: >> >>> Where is the user (DTS) and implementation of this change? If this is specific >>> to Xilinx, why you do not have device specific compatible? >> [Piyush]: >> We have dedicated irq line for hibernation feature, "hiber" irq line triggers hibernation interrupt. >> DWC3 core supports the hibernation feature, we have a dedicated code which is yet to be upstreamed. >> As the hibernation feature provided by dwc3-core, so this will be supported by other SOC/vendors. > > But is hiber irq line present in other vendors? What confuses me is > adding not only "hiber" irq but also otg in completely new enum.
I will let Piyush to comment hiber IRQ. But I expect we don't have visibility what others are doing but this is line is not Xilinx invention that's why I expect IP from Synopsys have it by default but it is up to soc vendor if hibernation feature is enabled or not.
otg is already listed in Documentation/devicetree/bindings/usb/snps,dwc3.yaml
It is only about order. Driver is already using platform_get_irq_byname..() functions
I think any combination should be fine. Do we need to record used order or there is way in yaml to support any combination with dwc_usb3, host, peripheral, otg should be working (ignoring that hiber which should be likely there too).
Thanks, Michal
| |