lkml.org 
[lkml]   [2022]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/10] dt-bindings: memory: mt7621: add syscon as compatible string
    On Wed, Sep 14, 2022 at 11:54:45AM +0300, Arınç ÜNAL wrote:
    > Add syscon as a constant string on the compatible property as it's required
    > for the SoC to work. Update the example accordingly.

    It's not required. It's required to automagically create a regmap. That
    can be done yourself as well. The downside to adding 'syscon' is it
    requires a DT update. Maybe that's fine for this platform? I don't know.

    >
    > Fixes: 5278e4a181ff ("dt-bindings: memory: add binding for Mediatek's MT7621 SDRAM memory controller")
    > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
    > ---
    > .../bindings/memory-controllers/mediatek,mt7621-memc.yaml | 6 ++++--
    > 1 file changed, 4 insertions(+), 2 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml
    > index 85e02854f083..6ccdaf99c778 100644
    > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml
    > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml
    > @@ -11,7 +11,9 @@ maintainers:
    >
    > properties:
    > compatible:
    > - const: mediatek,mt7621-memc
    > + items:
    > + - const: mediatek,mt7621-memc
    > + - const: syscon
    >
    > reg:
    > maxItems: 1
    > @@ -25,6 +27,6 @@ additionalProperties: false
    > examples:
    > - |
    > memory-controller@5000 {
    > - compatible = "mediatek,mt7621-memc";
    > + compatible = "mediatek,mt7621-memc", "syscon";
    > reg = <0x5000 0x1000>;
    > };
    > --
    > 2.34.1
    >
    >

    \
     
     \ /
      Last update: 2022-09-14 17:14    [W:4.774 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site