Messages in this thread | | | Date | Wed, 14 Sep 2022 12:40:05 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v2 1/4] mmc: sdhci-tegra: Separate T19x and T23x SoC data |
| |
On Wed, Sep 14, 2022 at 03:26:25PM +0530, Prathamesh Shete wrote: > Create new SoC data structure for T23x platforms.
Can you please use consistent spelling of Tegra194 and Tegra234 here and in the subject? That makes it a bit easier to search for things.
> StreamID programming is one of the additional feature > added in Tegra234 and later chips
That's a bit confusing because this patch doesn't do anything with stream ID programming. Perhaps defer that comment to when it becomes relevant?
Thierry
> > Signed-off-by: Aniruddha Tvs Rao <anrao@nvidia.com> > Signed-off-by: Prathamesh Shete <pshete@nvidia.com> > --- > drivers/mmc/host/sdhci-tegra.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 2d2d8260c681..a6c5bbae77b4 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -1556,7 +1556,21 @@ static const struct sdhci_tegra_soc_data soc_data_tegra194 = { > .max_tap_delay = 139, > }; > > +static const struct sdhci_tegra_soc_data soc_data_tegra234 = { > + .pdata = &sdhci_tegra186_pdata, > + .dma_mask = DMA_BIT_MASK(39), > + .nvquirks = NVQUIRK_NEEDS_PAD_CONTROL | > + NVQUIRK_HAS_PADCALIB | > + NVQUIRK_DIS_CARD_CLK_CONFIG_TAP | > + NVQUIRK_ENABLE_SDR50 | > + NVQUIRK_ENABLE_SDR104 | > + NVQUIRK_HAS_TMCLK, > + .min_tap_delay = 95, > + .max_tap_delay = 111, > +}; > + > static const struct of_device_id sdhci_tegra_dt_match[] = { > + { .compatible = "nvidia,tegra234-sdhci", .data = &soc_data_tegra234 }, > { .compatible = "nvidia,tegra194-sdhci", .data = &soc_data_tegra194 }, > { .compatible = "nvidia,tegra186-sdhci", .data = &soc_data_tegra186 }, > { .compatible = "nvidia,tegra210-sdhci", .data = &soc_data_tegra210 }, > -- > 2.17.1 > [unhandled content-type:application/pgp-signature] | |