lkml.org 
[lkml]   [2022]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 3/8] remoteproc: qcom: Add compatible name for SC7280 ADSP
    From
    Date

    On 9/8/22 6:53 PM, Srinivasa Rao Mandadapu wrote:
    > Update adsp pil data and compatible name for loading ADSP
    > binary on SC7280 based platforms.
    >
    > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
    > ---
    > Changes since V5:
    > -- Rename adsp_sandbox_needed to has_iommu.
    > -- Change adsp binary extention name.
    > Changes since V3:
    > -- Rename is_adsp_sb_needed to adsp_sandbox_needed.
    > -- Update sc7280 compatible name entry in sorted order.
    > Changes since V2:
    > -- Initialize is_adsp_sb_needed flag.
    > -- Remove empty proxy pds array.
    >
    > drivers/remoteproc/qcom_q6v5_adsp.c | 16 ++++++++++++++++
    > 1 file changed, 16 insertions(+)
    >
    > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
    > index fa2ccac..02d17b4 100644
    > --- a/drivers/remoteproc/qcom_q6v5_adsp.c
    > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
    > @@ -702,6 +702,21 @@ static const struct adsp_pil_data adsp_resource_init = {
    > },
    > };
    >
    > +static const struct adsp_pil_data adsp_sc7280_resource_init = {
    > + .crash_reason_smem = 423,
    > + .firmware_name = "adsp.pbn",
    > + .load_state = "adsp",

    given that you mention load_state info please make sure you
    mention qcom,qmp as a required property in the bindings.

    > + .ssr_name = "lpass",
    > + .sysmon_name = "adsp",
    > + .ssctl_id = 0x14,
    > + .has_iommu = true,
    > + .auto_boot = true,
    > + .clk_ids = (const char*[]) {
    > + "gcc_cfg_noc_lpass", NULL
    > + },
    > + .num_clks = 1,

    bindings seem to mention 6 other required clocks any reason why
    they were skipped?

    AFAIK you'll also need lmx so you'll have to mention proxy_pd_names
    as well.

    > +};
    > +
    > static const struct adsp_pil_data cdsp_resource_init = {
    > .crash_reason_smem = 601,
    > .firmware_name = "cdsp.mdt",
    > @@ -740,6 +755,7 @@ static const struct adsp_pil_data wpss_resource_init = {
    >
    > static const struct of_device_id adsp_of_match[] = {
    > { .compatible = "qcom,qcs404-cdsp-pil", .data = &cdsp_resource_init },
    > + { .compatible = "qcom,sc7280-adsp-pil", .data = &adsp_sc7280_resource_init },
    > { .compatible = "qcom,sc7280-wpss-pil", .data = &wpss_resource_init },
    > { .compatible = "qcom,sdm845-adsp-pil", .data = &adsp_resource_init },
    > { },
    >

    \
     
     \ /
      Last update: 2022-09-14 11:33    [W:4.123 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site