lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 014/192] drm/amdgpu: fix hive reference leak when adding xgmi device
    Date
    From: YiPeng Chai <YiPeng.Chai@amd.com>

    [ Upstream commit f5994da72ba124a3d0463672fdfbec073e3bb72f ]

    Only amdgpu_get_xgmi_hive but no amdgpu_put_xgmi_hive
    which will leak the hive reference.

    Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    index 3adebb63680e0..ea2b74c0fd229 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    @@ -2482,12 +2482,14 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)
    if (!hive->reset_domain ||
    !amdgpu_reset_get_reset_domain(hive->reset_domain)) {
    r = -ENOENT;
    + amdgpu_put_xgmi_hive(hive);
    goto init_failed;
    }

    /* Drop the early temporary reset domain we created for device */
    amdgpu_reset_put_reset_domain(adev->reset_domain);
    adev->reset_domain = hive->reset_domain;
    + amdgpu_put_xgmi_hive(hive);
    }
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-13 16:14    [W:2.359 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site