lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 041/192] ALSA: usb-audio: Fix an out-of-bounds bug in __snd_usb_parse_audio_interface()
    Date
    From: Dongxiang Ke <kdx.glider@gmail.com>

    commit e53f47f6c1a56d2af728909f1cb894da6b43d9bf upstream.

    There may be a bad USB audio device with a USB ID of (0x04fa, 0x4201) and
    the number of it's interfaces less than 4, an out-of-bounds read bug occurs
    when parsing the interface descriptor for this device.

    Fix this by checking the number of interfaces.

    Signed-off-by: Dongxiang Ke <kdx.glider@gmail.com>
    Link: https://lore.kernel.org/r/20220906024928.10951-1-kdx.glider@gmail.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/usb/stream.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/usb/stream.c
    +++ b/sound/usb/stream.c
    @@ -1105,7 +1105,7 @@ static int __snd_usb_parse_audio_interfa
    * Dallas DS4201 workaround: It presents 5 altsettings, but the last
    * one misses syncpipe, and does not produce any sound.
    */
    - if (chip->usb_id == USB_ID(0x04fa, 0x4201))
    + if (chip->usb_id == USB_ID(0x04fa, 0x4201) && num >= 4)
    num = 4;

    for (i = 0; i < num; i++) {

    \
     
     \ /
      Last update: 2022-09-13 16:12    [W:2.650 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site