Messages in this thread | | | Date | Tue, 13 Sep 2022 14:48:47 +0200 | From | Johan Hovold <> | Subject | Re: Re: [PATCH v3] USB: serial: ftdi_sio: Convert to use dev_groups |
| |
On Mon, Sep 05, 2022 at 06:01:01PM +0800, Jiasheng Jiang wrote: > On Fri, Sep 02, 2022 at 10:52:52PM +0800, Greg KH wrote:
> >>> And again, have you tested this change? > >> > >> Every time I change the code, I recomplie it and check whether there are > >> errors. > >> Are there any other tests I need to do? > > > > Yes, boot with the device and make sure that the sysfs files are still > > there. You do have access to one of these devices, right? They are > > very very common. > > Sorry, I still have no idea how to boot with the device.
You need to buy an FTDI device and plug it into a machine with your patch applied to the running and make sure that you did not break anything.
> But if there is any wrong with the patch, you can tell me and I will continue > to revise it.
It is your job to test your patches.
Johan
| |