Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 13 Sep 2022 13:36:09 +0100 | Subject | Re: [PATCH v2 06/10] drm/msm/dp: fix aux-bus EP lifetime |
| |
Hi,
On Tue, Sep 13, 2022 at 9:58 AM Johan Hovold <johan+linaro@kernel.org> wrote: > > Device-managed resources allocated post component bind must be tied to > the lifetime of the aggregate DRM device or they will not necessarily be > released when binding of the aggregate device is deferred. > > This can lead resource leaks or failure to bind the aggregate device > when binding is later retried and a second attempt to allocate the > resources is made. > > For the DP aux-bus, an attempt to populate the bus a second time will > simply fail ("DP AUX EP device already populated"). > > Fix this by tying the lifetime of the EP device to the DRM device rather > than DP controller platform device. > > Fixes: c3bf8e21b38a ("drm/msm/dp: Add eDP support via aux_bus") > Cc: stable@vger.kernel.org # 5.19 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-)
This seems fine to me as a short term fix until we get the DP AUX populating moved to probe.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |