lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] mips: cavium: convert to DEFINE_SHOW_ATTRIBUTE
    Date
    Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.

    Signed-off-by: Liu Shixin <liushixin2@huawei.com>
    ---
    arch/mips/cavium-octeon/oct_ilm.c | 17 +++--------------
    1 file changed, 3 insertions(+), 14 deletions(-)

    diff --git a/arch/mips/cavium-octeon/oct_ilm.c b/arch/mips/cavium-octeon/oct_ilm.c
    index 6a4694538bb6..dc05262e85ff 100644
    --- a/arch/mips/cavium-octeon/oct_ilm.c
    +++ b/arch/mips/cavium-octeon/oct_ilm.c
    @@ -28,7 +28,7 @@ struct latency_info {
    static struct latency_info li;
    static struct dentry *dir;

    -static int show_latency(struct seq_file *m, void *v)
    +static int oct_ilm_show(struct seq_file *m, void *v)
    {
    u64 cpuclk, avg, max, min;
    struct latency_info curr_li = li;
    @@ -43,18 +43,7 @@ static int show_latency(struct seq_file *m, void *v)
    curr_li.interrupt_cnt, avg, max, min);
    return 0;
    }
    -
    -static int oct_ilm_open(struct inode *inode, struct file *file)
    -{
    - return single_open(file, show_latency, NULL);
    -}
    -
    -static const struct file_operations oct_ilm_ops = {
    - .open = oct_ilm_open,
    - .read = seq_read,
    - .llseek = seq_lseek,
    - .release = single_release,
    -};
    +DEFINE_SHOW_ATTRIBUTE(oct_ilm);

    static int reset_statistics(void *data, u64 value)
    {
    @@ -67,7 +56,7 @@ DEFINE_DEBUGFS_ATTRIBUTE(reset_statistics_ops, NULL, reset_statistics, "%llu\n")
    static void init_debugfs(void)
    {
    dir = debugfs_create_dir("oct_ilm", 0);
    - debugfs_create_file("statistics", 0222, dir, NULL, &oct_ilm_ops);
    + debugfs_create_file("statistics", 0222, dir, NULL, &oct_ilm_fops);
    debugfs_create_file("reset", 0222, dir, NULL, &reset_statistics_ops);
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-09-13 11:37    [W:3.784 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site