lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [External] Re: [PATCH V2 2/5] erofs: introduce fscache-based domain
From


在 2022/9/14 11:02, JeffleXu 写道:
>
>
> On 9/2/22 6:53 PM, Jia Zhu wrote:
>
>> int erofs_fscache_register_cookie(struct super_block *sb,
>> struct erofs_fscache **fscache,
>> char *name, bool need_inode)
>> @@ -495,7 +581,8 @@ int erofs_fscache_register_fs(struct super_block *sb)
>> char *name;
>> int ret = 0;
>>
>> - name = kasprintf(GFP_KERNEL, "erofs,%s", sbi->opt.fsid);
>> + name = kasprintf(GFP_KERNEL, "erofs,%s",
>> + sbi->domain ? sbi->domain->domain_id : sbi->opt.fsid);
>> if (!name)
>> return -ENOMEM;
>>
>
> What if domain_id and fsid has the same value?
>
> How about the format "erofs,<domain_id>,<fsid>"? While in the
> non-share-domain mode, is the format like "erofs,,<fsid>" or the default
> "erofs,<fsid>"?
>
Thanks for pointing this out. I'll revise it.
>

\
 
 \ /
  Last update: 2022-09-14 05:16    [W:0.073 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site