lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 04/12] staging: vt6655: Cleanup and rename function MACbSafeSoftwareReset
From
On 9/13/22 12:12, Dan Carpenter wrote:
> On Sun, Sep 11, 2022 at 12:46:04PM +0200, Philipp Hortmann wrote:
>> Rename function MACbSafeSoftwareReset to vt6655_mac_save_soft_reset and
>> abyTmpRegData to tmp_reg_data to avoid CamelCase which is not accepted by
>> checkpatch.pl. Remove return value bRetVal as it is unused by the calling
>> functions.
> Please don't mix this kind of stuff into a patch like this.
>

In the past Greg let me know that I used to many patches for a change in
the same lines of code and that it would be easier for him to review
when less patches do the same.

As you wrote I am changing to many things at once. Sorry for breaking
your automatism.

I will consider your hints for the next patches.

Thanks

Bye Philipp

\
 
 \ /
  Last update: 2022-09-13 20:46    [W:0.088 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site