Messages in this thread | | | Date | Tue, 13 Sep 2022 18:13:21 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 5.19 123/192] net: fec: Use a spinlock to guard `fep->ptp_clk_on` |
| |
On Tue, Sep 13, 2022 at 04:19:17PM +0200, Marc Kleine-Budde wrote: > Hello Greg, > > On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote: > > From: Csókás Bence <csokas.bence@prolan.hu> > > > > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ] > > > > Mutexes cannot be taken in a non-preemptible context, > > causing a panic in `fec_ptp_save_state()`. Replacing > > `ptp_clk_mutex` by `tmreg_lock` fixes this. > > > > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled") > > Fixes: f79959220fa5 ("fec: Restart PPS after link state change") > > Reported-by: Marc Kleine-Budde <mkl@pengutronix.de> > > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@pengutronix.de/ > > Signed-off-by: Csókás Bence <csokas.bence@prolan.hu> > > Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> # Toradex Apalis iMX6 > > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@prolan.hu > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > Signed-off-by: Sasha Levin <sashal@kernel.org> > > there's a revert pending for this patch: > > | https://lore.kernel.org/all/20220912070143.98153-1-francesco.dolcini@toradex.com > > ...as it causes troubles in 6.0-rc4: > > | https://lore.kernel.org/all/20220907143915.5w65kainpykfobte@pengutronix.de/ > | https://lore.kernel.org/all/CAHk-=wj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eheb3A9WHw@mail.gmail.com/ > > please drop this patch.
Now dropped from all 3 queues, thanks.
greg k-h
| |