Messages in this thread | | | Date | Mon, 12 Sep 2022 21:14:09 +0300 | Subject | Re: [PATCH 1/2] thermal: Introduce CONFIG_QCOM_THERMAL in Makefile and qcom/Kconfig | From | Dmitry Baryshkov <> |
| |
On 12/09/2022 20:11, Bhupesh Sharma wrote: > > > On 9/12/22 1:08 AM, Dmitry Baryshkov wrote: >> On Sun, 11 Sept 2022 at 21:42, Bhupesh Sharma >> <bhupesh.sharma@linaro.org> wrote: >>> >>> Introduce CONFIG_QCOM_THERMAL to allow better control >>> over selection of various Qualcomm Thermal drivers >>> available inside qcom/ directory. >>> >>> This is a preparatory change to allow new drivers to >>> be added inside qcom/ directory in a more structured >>> fashion. >>> >>> Cc: Bjorn Andersson <andersson@kernel.org> >>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> >>> Cc: Amit Kucheria <amitk@kernel.org> >>> Cc: Thara Gopinath <thara.gopinath@gmail.com> >>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >>> --- >>> drivers/thermal/Makefile | 2 +- >>> drivers/thermal/qcom/Kconfig | 12 ++++++++++++ >>> 2 files changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile >>> index def8e1a0399c..a12b647be0d1 100644 >>> --- a/drivers/thermal/Makefile >>> +++ b/drivers/thermal/Makefile >>> @@ -52,7 +52,7 @@ obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o >>> obj-y += intel/ >>> obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ >>> obj-y += st/ >>> -obj-$(CONFIG_QCOM_TSENS) += qcom/ >>> +obj-$(CONFIG_QCOM_THERMAL) += qcom/ >> >> Following other platforms around qcom, I think just `obj-y += qcom/` >> would work well enough. > > I have no strong opinion on using `obj-y += qcom/` here, but I would > still like us to define a CONFIG_QCOM_THERMAL like flag in the > qcom/Kconfig, similar to the ST platforms which use similar selection > mechanism via 'CONFIG_ST_THERMAL'.
`QCOM_THERMAL' is fine for me.
> > Thanks. > >>> obj-y += tegra/ >>> obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o >>> obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o >>
-- With best wishes Dmitry
| |