lkml.org 
[lkml]   [2022]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 1/8] dt-bindings: power: supply: Add MediaTek MT6370 Charger
Hi,

On Tue, Sep 06, 2022 at 04:33:57PM +0800, ChiaEn Wu wrote:
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> Add MediaTek MT6370 Charger binding documentation.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
> .../power/supply/mediatek,mt6370-charger.yaml | 88 ++++++++++++++++++++++
> 1 file changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> new file mode 100644
> index 0000000..bd09a0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6370 Battery Charger
> +
> +maintainers:
> + - ChiaEn Wu <chiaen_wu@richtek.com>
> +
> +description: |
> + This module is part of the MT6370 MFD device.
> + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-charger
> +
> + interrupts:
> + description: |
> + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
> + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
> + are required.

This does not look like a useful description. It just lists the
below in wrong order?

> + items:
> + - description: BC1.2 done irq
> + - description: usb plug in irq
> + - description: mivr irq

I had to lookup, that mivr is supposed to mean "minimum input voltage regulation"
for Mediatek/Richtek. Please spell it out here.

-- Sebastian

> +
> + interrupt-names:
> + items:
> + - const: attach_i
> + - const: uvp_d_evt
> + - const: mivr
> +
> + io-channels:
> + description: |
> + Use ADC channel to read VBUS, IBUS, IBAT, etc., info.
> + minItems: 1
> + items:
> + - description: |
> + VBUS voltage with lower accuracy (+-75mV) but higher measure
> + range (1~22V)
> + - description: |
> + VBUS voltage with higher accuracy (+-30mV) but lower measure
> + range (1~9.76V)
> + - description: the main system input voltage
> + - description: battery voltage
> + - description: battery temperature-sense input voltage
> + - description: IBUS current (required)
> + - description: battery current
> + - description: |
> + regulated output voltage to supply for the PWM low-side gate driver
> + and the bootstrap capacitor
> + - description: IC junction temperature
> +
> + io-channel-names:
> + minItems: 1
> + items:
> + - const: vbusdiv5
> + - const: vbusdiv2
> + - const: vsys
> + - const: vbat
> + - const: ts_bat
> + - const: ibus
> + - const: ibat
> + - const: chg_vddp
> + - const: temp_jc
> +
> + usb-otg-vbus-regulator:
> + type: object
> + description: OTG boost regulator.
> + unevaluatedProperties: false
> + $ref: /schemas/regulator/regulator.yaml#
> +
> + properties:
> + enable-gpios:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - interrupts
> + - interrupt-names
> + - io-channels
> +
> +additionalProperties: false
> +
> +...
> --
> 2.7.4
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-09-12 12:24    [W:0.074 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site