lkml.org 
[lkml]   [2022]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 7/9] arm64: dts: qcom: sm6115: Add basic soc dtsi
From
On 11/09/2022 12:22, Iskren Chernev wrote:
> basic-state { // this matches the first state in oneOf
> pins: "gpio1";
> funciton: "normal";
> };
>
> nested-state {
> some-pins { // this matches the second state in oneOf
> pins: "gpio1";
> funciton: "normal";
> };
> other-pins {
> pins: "gpio2"
> funciton: "normal";
> };
> }
>
> // but also, matching second state in oneOf
> nested-basic-state {
> pinconf {
> pins: "gpio1";
> funciton: "normal";
> };
> };
> };
>
> So I'm saying, we should either choose basic-state and nested-state, in which
> case we don't need the "^pinconf$" variant, or we can have nested-state and
> nested-basic-state, in which case we don't need the 1st case of the oneOf.

Ah, I get it.

>
> Otherwise people have to choose between basic-state and nested-basic-state,
> which are equivalent in semantics.

Yeah, I can drop pinconf. I put it in the PMIC because it was used, but
I don't find it for TLMM pinctrl nodes.

>
> On a tangent -- why specifying the .* regex of pinctrl subnodes has effect on
> pinctrl references in other nodes. I.e I don't understand why this fix fixes
> the issue (but it does).

Because it works on DTB and finds linux,phandle. This might be some bug
in dtschema, but anyway better to have a bit stricter patterns in bindings.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-11 12:27    [W:0.092 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site