Messages in this thread | | | Date | Sat, 10 Sep 2022 07:36:52 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: pi433: Fix string form declaration |
| |
On Fri, Sep 09, 2022 at 10:50:57PM +0000, Burak Ozdemir wrote: > I have been analyzing todo tasks from `Kernel Janitors Projects` and saw > the following task > > From: Jeff Garzik > > 1) The string form > [const] char *foo = "blah"; > creates two variables in the final assembly output, a static string, and a > char pointer to the static string. The alternate string form > [const] char foo[] = "blah"; > is better because it declares a single variable. > > That's why I changed that char * to static const[].
I'm sorry, but I have no context here at all for what this is in response to.
Remember, some of us get hundreds of changes each day to review, and we have the short-term memory of a squirrel. Always include proper context in an email message so that we know what is going on.
thanks,
greg k-h
| |