lkml.org 
[lkml]   [2022]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH linux-next] ACPI: APEI: Remove the unneeded result variable
On Wed, Aug 31, 2022 at 5:31 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value erst_get_record_id_begin() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/acpi/apei/erst.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index 31b077eedb58..247989060e29 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -1020,14 +1020,10 @@ static int reader_pos;
>
> static int erst_open_pstore(struct pstore_info *psi)
> {
> - int rc;
> -
> if (erst_disable)
> return -ENODEV;
>
> - rc = erst_get_record_id_begin(&reader_pos);
> -
> - return rc;
> + return erst_get_record_id_begin(&reader_pos);
> }
>
> static int erst_close_pstore(struct pstore_info *psi)
> --

Can you please combine this patch with the other analogous one you
sent for APEI?

\
 
 \ /
  Last update: 2022-09-10 17:52    [W:0.040 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site