lkml.org 
[lkml]   [2022]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] livepatch: Add a missing newline character in klp_module_coming()
On Tue 2022-08-30 19:28:55, Zhen Lei wrote:
> The error message is not printed immediately because it does not end with
> a newline character.
>
> Before:
> root@localhost:~# insmod vmlinux.ko
> insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
>
> After:
> root@localhost:~# insmod vmlinux.ko
> [ 43.982558] livepatch: vmlinux.ko: invalid module name
> insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
>
> Fixes: dcf550e52f56 ("livepatch: Disallow vmlinux.ko")
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Great catch! The message is not pushed to the console because
the line is not finished and might be eventually extended by pr_cont().

Reviewed-by: Petr Mladek <pmladek@suse.com>

The fix is trivial. I have pushed it into livepatching/livepatching.git,
branch for-6.1/fixes.

Best Regards,
Petr

\
 
 \ /
  Last update: 2022-09-01 17:10    [W:0.044 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site