Messages in this thread | | | Date | Thu, 1 Sep 2022 16:49:05 +0200 | Subject | Re: [PATCH v3 2/2] virt: vbox: Remove unproper information | From | Hans de Goede <> |
| |
Hi,
On 9/1/22 16:46, Jiasheng Jiang wrote: > When drivers are working properly, they are quiet. > Therefore, the vbg_info() should be removed. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/virt/vboxguest/vboxguest_linux.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c > index 6fc81347ae72..c47e62dc55da 100644 > --- a/drivers/virt/vboxguest/vboxguest_linux.c > +++ b/drivers/virt/vboxguest/vboxguest_linux.c > @@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) > > pci_set_drvdata(pci, gdev); > > - vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n", > - gdev->misc_device.minor, pci->irq, gdev->io_port, > - &mmio, &mmio_len); > - > return 0; > > err_unregister_misc_device_user:
| |