Messages in this thread | | | Subject | Re: [PATCH next-next 0/2] net: vlan: two small refactors to make code more concise | From | Paolo Abeni <> | Date | Thu, 01 Sep 2022 15:28:40 +0200 |
| |
Hello,
On Wed, 2022-08-31 at 12:09 +0800, Ziyang Xuan wrote: > Give two small refactors to make code more concise. > > Ziyang Xuan (2): > net: vlan: remove unnecessary err variable in vlan_init_net() > net: vlan: reduce indentation level in __vlan_find_dev_deep_rcu() > > net/8021q/vlan.c | 5 +---- > net/8021q/vlan_core.c | 22 +++++++++------------- > 2 files changed, 10 insertions(+), 17 deletions(-)
The patches look correct to me, but I think is better to defer this kind of nun-functional refactors to some work actually doing new stuff, to avoid unneeded noise.
Note that I merged a few other clean-up recently, but e.g. they at least formally removed some unneeded branch.
Sorry, I'm not going to apply this series.
Cheers,
Paolo
| |