lkml.org 
[lkml]   [2022]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 14/14] fs/buffer: remove bh_submit_read() helper
    Date
    bh_submit_read() has no user anymore, just remove it.

    Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    ---
    fs/buffer.c | 25 -------------------------
    include/linux/buffer_head.h | 1 -
    2 files changed, 26 deletions(-)

    diff --git a/fs/buffer.c b/fs/buffer.c
    index 2cccc7586b99..b4c9fff3ab6c 100644
    --- a/fs/buffer.c
    +++ b/fs/buffer.c
    @@ -3025,31 +3025,6 @@ void __bh_read_batch(int nr, struct buffer_head *bhs[],
    }
    EXPORT_SYMBOL(__bh_read_batch);

    -/**
    - * bh_submit_read - Submit a locked buffer for reading
    - * @bh: struct buffer_head
    - *
    - * Returns zero on success and -EIO on error.
    - */
    -int bh_submit_read(struct buffer_head *bh)
    -{
    - BUG_ON(!buffer_locked(bh));
    -
    - if (buffer_uptodate(bh)) {
    - unlock_buffer(bh);
    - return 0;
    - }
    -
    - get_bh(bh);
    - bh->b_end_io = end_buffer_read_sync;
    - submit_bh(REQ_OP_READ, bh);
    - wait_on_buffer(bh);
    - if (buffer_uptodate(bh))
    - return 0;
    - return -EIO;
    -}
    -EXPORT_SYMBOL(bh_submit_read);
    -
    void __init buffer_init(void)
    {
    unsigned long nrpages;
    diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
    index b415d8bc2a09..9b6556d3f110 100644
    --- a/include/linux/buffer_head.h
    +++ b/include/linux/buffer_head.h
    @@ -230,7 +230,6 @@ int submit_bh(blk_opf_t, struct buffer_head *);
    void write_boundary_block(struct block_device *bdev,
    sector_t bblock, unsigned blocksize);
    int bh_uptodate_or_lock(struct buffer_head *bh);
    -int bh_submit_read(struct buffer_head *bh);
    int __bh_read(struct buffer_head *bh, blk_opf_t op_flags, bool wait);
    void __bh_read_batch(int nr, struct buffer_head *bhs[],
    blk_opf_t op_flags, bool force_lock);
    --
    2.31.1
    \
     
     \ /
      Last update: 2022-09-01 15:28    [W:5.542 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site