Messages in this thread | | | Date | Thu, 1 Sep 2022 16:16:34 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1] regmap: introduce value tracing for regmap bulk operations |
| |
On Wed, Aug 31, 2022 at 03:45:30AM +0300, Dmitry Rokosov wrote:
...
> > > + if (val) > > > + memcpy(__get_dynamic_array(buf), val, val_len); > > > > I'm probably missing something, but what this condition prevents from? > > In general, this condition prevents memcpy from being executed when > tracepoint is called with a null pointed buffer.
If we got a NULL pointer here, we already in a lot of troubles. I believe the check is not needed.
Otherwise the function prints garbage.
I will send a series to remove that and clean up the file.
-- With Best Regards, Andy Shevchenko
| |