Messages in this thread | | | Date | Thu, 1 Sep 2022 14:55:30 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_" |
| |
Hi,
On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote: > With the introduction of KUnit, IGT is no longer the only option to run > the DRM unit tests, as the tests can be run through kunit-tool or on > real hardware with CONFIG_KUNIT. > > Therefore, remove the "igt_" prefix from the tests and replace it with > the "test_drm_" prefix, making the tests' names independent from the tool > used. > > Signed-off-by: Maíra Canal <mairacanal@riseup.net> > > --- > v1 -> v2: https://lore.kernel.org/dri-devel/20220830211603.191734-1-mairacanal@riseup.net/ > - Change "drm_" prefix to "test_drm_", as "drm_" can be a bit confusing (Jani Nikula).
I appreciate it's a bit of a bikeshed but I disagree with this. The majority of the kunit tests already out there start with the framework name, including *all* the examples in the kunit doc. Plus, it's fairly obvious that it's a test, kunit is only about running tests in the first place.
Maxime
| |