Messages in this thread | | | Date | Thu, 1 Sep 2022 14:25:54 +0530 | Subject | Re: [PATCH] remoteproc: report firmware name on load failures | From | Mukesh Ojha <> |
| |
hi,
On 8/31/2022 9:47 PM, Krzysztof Kozlowski wrote: > remoteproc error messages like: > remoteproc remoteproc0: request_firmware failed: -2 > remoteproc remoteproc1: request_firmware failed: -2 > are difficult to debug as one actually have no clue which device > reported it and which firmware is missing. Be verbose and print the > name of the failed firmware. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/remoteproc/remoteproc_core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index e5279ed9a8d7..71cd7ed7a970 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -1923,7 +1923,8 @@ int rproc_trigger_recovery(struct rproc *rproc) > /* load firmware */ > ret = request_firmware(&firmware_p, rproc->firmware, dev); > if (ret < 0) { > - dev_err(dev, "request_firmware failed: %d\n", ret); > + dev_err(dev, "request_firmware %s failed: %d\n", > + rproc->firmware, ret); > goto unlock_mutex; > } > > @@ -2023,7 +2024,8 @@ int rproc_boot(struct rproc *rproc) > /* load firmware */ > ret = request_firmware(&firmware_p, rproc->firmware, dev); > if (ret < 0) { > - dev_err(dev, "request_firmware failed: %d\n", ret); > + dev_err(dev, "request_firmware %s failed: %d\n", > + rproc->firmware, ret);
Good to have this. Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
> goto downref_rproc; > } >
-Mukesh
| |