Messages in this thread | | | Date | Thu, 1 Sep 2022 16:00:26 +0800 | Subject | Re: [PATCH] mm: remove BUG_ON() in __isolate_free_page() | From | Kefeng Wang <> |
| |
On 2022/9/1 15:37, David Hildenbrand wrote: > On 01.09.22 03:50, Kefeng Wang wrote: >> Drop unneed comment and blank, adjust the variable, and the most >> important is to delete BUG_ON(). The page passed is always buddy >> page into __isolate_free_page() from compaction, page_isolation >> and page_reporting, and the caller also check the return, BUG_ON() >> is a too drastic measure, remove it. > Why not WARN_ON_ONCE then? But yeah, maybe this really isn't of any > value anymore.
or VM_WARN_ON(), but I think this bug_on is useless after check all calllers,
so let's drop it if no objection.
| |