Messages in this thread Patch in this message | | | Date | Thu, 1 Sep 2022 15:36:43 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v2 10/11] sh: mm: Convert to GENERIC_IOREMAP |
| |
On 08/21/22 at 12:06am, Christoph Hellwig wrote: > > +void __iomem * > > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val); > > +#define arch_ioremap arch_ioremap > > Shouldn't this still be under CONFIG_MMU?
Yeah, you are right, will put them under CONFIG_MMU.
I thought making GENERIC_IOREMAP depend MMU in Kconfig will contain that. But people can manually set the Kconfig item freely. Thanks for pointing it out.
diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 5f220e903e5a..b63ad4698cf8 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -25,6 +25,7 @@ config SUPERH select GENERIC_SCHED_CLOCK select GENERIC_SMP_IDLE_THREAD select GUP_GET_PTE_LOW_HIGH if X2TLB + select GENERIC_IOREMAP if MMU
>
| |