Messages in this thread | | | From | Mathieu Poirier <> | Date | Thu, 1 Sep 2022 10:52:08 -0600 | Subject | Re: [PATCH v9 0/2] Add support for UltraSoc System Memory Buffer |
| |
On Thu, 1 Sept 2022 at 07:12, hejunhao <hejunhao3@huawei.com> wrote: > > Gentle ping. Any comment or suggestion is appreciated. >
There are a few patchset that are both substantial and complex to review on the log. As such reviewing will take longer than usual.
> thanks. > > On 2022/8/18 21:22, Junhao He wrote: > > Add support for UltraSoc System Memory Buffer. > > > > Change since v8: > > - Insert a blank line at the end of the config tag in Kconfig. > > - Fix the "llseek" initialization. > > - Link: https://lore.kernel.org/linux-arm-kernel/20220816131634.38195-1-hejunhao3@huawei.com/ > > > > Change since v7: > > - Use the macros for register bit flags and numbers of resource. > > - Fix punctuation. > > - Update the Date tag and the KernelVersion tag in the document. > > - Link: https://lore.kernel.org/lkml/20220712091353.34540-1-hejunhao3@huawei.com/ > > > > Change since v6: > > - Modify the code style and driver description according to Suzuki's comment. > > - Modify configuration of "drvdata->reading", to void problems in open/read > > concurrency scenario. > > - Rename the macro of "SMB_FLOW_MASK". > > - Use the "handle->head" to determine the page number and offset. > > - Link: https://lore.kernel.org/linux-arm-kernel/20220606130223.57354-1-liuqi115@huawei.com/ > > > > Change since v5: > > - Address the comments from Suzuki, add some comments in SMB document, and modify > > configuration of "drvdata->reading", to void problems in multi-core concurrency scenario > > - Link: https://lore.kernel.org/linux-arm-kernel/20220416083953.52610-1-liuqi115@huawei.com/ > > > > Change since v4: > > - Add a simple document of SMB driver according to Suzuki's comment. > > - Address the comments from Suzuki. > > - Link: https://lore.kernel.org/linux-arm-kernel/20220128061755.31909-1-liuqi115@huawei.com/ > > > > Change since v3: > > - Modify the file header according to community specifications. > > - Address the comments from Mathieu. > > - Link: https://lore.kernel.org/linux-arm-kernel/20211118110016.40398-1-liuqi115@huawei.com/ > > > > Change since v2: > > - Move ultrasoc driver to drivers/hwtracing/coresight. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-November/007310.html > > > > Change since v1: > > - Drop the document of UltraSoc according to Mathieu's comment. > > - Add comments to explain some private hardware settings. > > - Address the comments from Mathieu. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-August/006842.html > > > > Change since RFC: > > - Move driver to drivers/hwtracing/coresight/ultrasoc. > > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in > > basic tracing function. > > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. > > - Address the comments from Mathieu and Suzuki. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html > > > > Qi Liu (2): > > drivers/coresight: Add UltraSoc System Memory Buffer driver > > Documentation: Add document for UltraSoc SMB drivers > > > > .../sysfs-bus-coresight-devices-ultra_smb | 31 + > > .../trace/coresight/ultrasoc-smb.rst | 80 +++ > > drivers/hwtracing/coresight/Kconfig | 11 + > > drivers/hwtracing/coresight/Makefile | 1 + > > drivers/hwtracing/coresight/ultrasoc-smb.c | 636 ++++++++++++++++++ > > drivers/hwtracing/coresight/ultrasoc-smb.h | 115 ++++ > > 6 files changed, 874 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb > > create mode 100644 Documentation/trace/coresight/ultrasoc-smb.rst > > create mode 100644 drivers/hwtracing/coresight/ultrasoc-smb.c > > create mode 100644 drivers/hwtracing/coresight/ultrasoc-smb.h > > >
| |