Messages in this thread | | | Date | Thu, 1 Sep 2022 12:57:37 -0600 | Subject | Re: [PATCH v2] tools: Add new "test" taint to kernel-chktaint | From | Shuah Khan <> |
| |
On 8/23/22 22:41, David Gow wrote: > On Wed, Aug 24, 2022 at 12:19 PM Joe Fradley <joefradley@google.com> wrote: >> >> Commit c272612cb4a2 ("kunit: Taint the kernel when KUnit tests are run") >> added a new taint flag for when in-kernel tests run. This commit adds >> recognition of this new flag in kernel-chktaint. >>
What happens without this change? It isn't clear what this change is fixing.
>> Reviewed-by: David Gow <davidgow@google.com> >> Signed-off-by: Joe Fradley <joefradley@google.com> >> --- >> Changes in v2: >> - based off of kselftest/kunit branch >> - Added David's Reviewed-by tag >> > > This still looks good to me. > > Unless anyone objects, I guess we'll take this through the KUnit > branch (which, after all, is where the taint was originally added). > I've added it to the list for 6.1, but it technically could be > considered a fix for 6.0 as well. >
I can definitely take this for Linux 6.0 with additional information on the problems seen without this change.
thanks, -- Shuah
| |