Messages in this thread | | | Subject | Re: [PATCH v3 19/19] hwmon: (mr75203) fix coding style space errors | Date | Thu, 1 Sep 2022 21:40:41 +0300 | From | "Farber, Eliav" <> |
| |
On 9/1/2022 8:09 PM, Guenter Roeck wrote: > On 9/1/22 08:31, Farber, Eliav wrote: >> On 9/1/2022 5:46 PM, Guenter Roeck wrote: >>> On Thu, Sep 01, 2022 at 05:21:43PM +0300, Farber, Eliav wrote: >>>> On 8/31/2022 3:15 PM, Andy Shevchenko wrote: >>>> > On Tue, Aug 30, 2022 at 07:22:12PM +0000, Eliav Farber wrote: >>>> > > Fix: "ERROR: space required before the open parenthesis '('" >>>> > >>>> > This patch may have other fixes like adding new blank lines >>>> (noted in one >>>> > of the patches in the series), etc. >>>> This patch fixed a specific space error which existed before my >>>> changes >>>> and repeated many time. >>>> I fixed the blank line I added a previous patch (but is it isn’t an >>>> error >>>> reported by checkpatch). >>> >>> That should really be fixed where it was introduced, not be introduced >>> and fixed here. >> >> >> So what do you suggest? >> I can drop the patch from this series and ignore it or move it to be the >> first patch in the series, or publish it separately later on. >> I had it because it was annoying seeing existing checkpatch errors when >> I came to check my change. >> > > Sorry, you lost me. I referred to "I fixed the blank line I added > a previous patch". That should not be fixed in this patch but be dropped > from the patch where you introduced it. Did I misunderstand your > comment ?
Indeed I fixed the blank line in the original patch in which it was introduced. Patch #19 only addresses previously existing space related checkpatch errors.
-- Thanks, Eliav
| |