Messages in this thread | | | Date | Thu, 1 Sep 2022 10:00:28 -0700 | Subject | Re: [Intel-gfx] [PATCH v7 08/15] mei: extend timeouts on slow devices. | From | "Ceraolo Spurio, Daniele" <> |
| |
<snip>
> @@ -990,7 +991,6 @@ static int mei_me_d0i3_enter(struct mei_device *dev) > static int mei_me_d0i3_exit_sync(struct mei_device *dev) > { > struct mei_me_hw *hw = to_me_hw(dev); > - unsigned long timeout = mei_secs_to_jiffies(MEI_D0I3_TIMEOUT); > int ret; > u32 reg; > > @@ -1013,7 +1013,8 @@ static int mei_me_d0i3_exit_sync(struct mei_device *dev) > > mutex_unlock(&dev->device_lock); > wait_event_timeout(dev->wait_pg, > - dev->pg_event == MEI_PG_EVENT_INTR_RECEIVED, timeout); > + dev->pg_event == MEI_PG_EVENT_INTR_RECEIVED, > + dev->timeouts.pgi);
Shouldn't this be timeouts.d0i3, given that it replaces mei_secs_to_jiffies(MEI_D0I3_TIMEOUT)? Apart from this, all the other replacements look ok, so with this fixed:
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Daniele
> mutex_lock(&dev->device_lock); > > if (dev->pg_event != MEI_PG_EVENT_INTR_RECEIVED) { >
| |