Messages in this thread | | | Date | Tue, 9 Aug 2022 16:05:43 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface |
| |
On Sat 30 Jul 04:17 CDT 2022, Akhil P Oommen wrote:
> > Some clients like adreno gpu driver would like to ensure that its gdsc > is collapsed at hardware during a gpu reset sequence. This is because it > has a votable gdsc which could be ON due to a vote from another subsystem > like tz, hyp etc or due to an internal hardware signal. To allow > this, gpucc driver can expose an interface to the client driver using > reset framework. Using this the client driver can trigger a polling within > the gdsc driver. > > This series is rebased on top of linus's master branch. > > Related discussion: https://patchwork.freedesktop.org/patch/493144/ >
Forgive me if I'm assuming too much, but isn't this an extension of:
85a3d920d30a ("clk: qcom: Add a dummy enable function for GX gdsc")
With the additional requirement that disable should really ensure that the GDSC is turned off?
Regards, Bjorn
> > Akhil P Oommen (5): > dt-bindings: clk: qcom: Support gpu cx gdsc reset > clk: qcom: Allow custom reset ops > clk: qcom: gpucc-sc7280: Add cx collapse reset support > clk: qcom: gdsc: Add a reset op to poll gdsc collapse > arm64: dts: qcom: sc7280: Add Reset support for gpu > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ > drivers/clk/qcom/gdsc.c | 23 +++++++++++++++++++---- > drivers/clk/qcom/gdsc.h | 7 +++++++ > drivers/clk/qcom/gpucc-sc7280.c | 6 ++++++ > drivers/clk/qcom/reset.c | 6 ++++++ > drivers/clk/qcom/reset.h | 2 ++ > include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++ > 7 files changed, 46 insertions(+), 4 deletions(-) > > -- > 2.7.4 >
| |