lkml.org 
[lkml]   [2022]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] KVM: selftests: Use getcpu() instead of sched_getcpu() in rseq_test
Date
* Florian Weimer:

> * Gavin Shan:
>
>> sched_getcpu() is glibc dependent and it can simply return the CPU
>> ID from the registered rseq information, as Florian Weimer pointed.
>> In this case, it's pointless to compare the return value from
>> sched_getcpu() and that fetched from the registered rseq information.
>>
>> Fix the issue by replacing sched_getcpu() with getcpu(), as Florian
>> suggested. The comments are modified accordingly.
>
> Note that getcpu was added in glibc 2.29, so perhaps you need to perform
> a direct system call?

One more thing: syscall(__NR_getcpu) also has the advantage that it
wouldn't have to be changed again if node IDs become available via rseq
and getcpu is implemented using that.

Thanks,
Florian

\
 
 \ /
  Last update: 2022-08-09 09:18    [W:0.073 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site