Messages in this thread | | | Date | Tue, 9 Aug 2022 13:04:46 -0700 | Subject | Re: [PATCH] scsi: aic79xx: make read-only array tok_list static const | From | Bart Van Assche <> |
| |
On 8/9/22 11:25, Colin Ian King wrote: > Don't populate the read-only array tok_list on the stack but instead make > it static const. Also makes the object code a little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/scsi/aic7xxx/aic79xx_osm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c > index 928099163f0f..4ed40e6c5522 100644 > --- a/drivers/scsi/aic7xxx/aic79xx_osm.c > +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c > @@ -1044,7 +1044,7 @@ ahd_parse_brace_option(char *opt_name, char *opt_arg, char *end, int depth, > int instance; > int targ; > int done; > - char tok_list[] = {'.', ',', '{', '}', '\0'}; > + static const char tok_list[] = {'.', ',', '{', '}', '\0'};
Has it been considered to write the above code as follows?
static const char tok_list[] = ".,{}";
Thanks,
Bart.
| |