Messages in this thread | | | Date | Tue, 9 Aug 2022 07:50:35 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v2 1/1] bpf: Drop unprotected find_vpid() in favour of find_get_pid() |
| |
On Wed, 03 Aug 2022, Jiri Olsa wrote:
> On Wed, Aug 03, 2022 at 02:48:21PM +0100, Lee Jones wrote: > > The documentation for find_pid() clearly states: > > nit: typo find_vpid
Sorry missed this.
Will fix.
> > "Must be called with the tasklist_lock or rcu_read_lock() held." > > > > Presently we do neither. > > > > Let's use find_get_pid() which searches for the vpid, then takes a > > reference to it preventing early free, all within the safety of > > rcu_read_lock(). Once we have our reference we can safely make use of > > it up until the point it is put. > > > > Cc: Alexei Starovoitov <ast@kernel.org> > > Cc: Daniel Borkmann <daniel@iogearbox.net> > > Cc: John Fastabend <john.fastabend@gmail.com> > > Cc: Andrii Nakryiko <andrii@kernel.org> > > Cc: Martin KaFai Lau <martin.lau@linux.dev> > > Cc: Song Liu <song@kernel.org> > > Cc: Yonghong Song <yhs@fb.com> > > Cc: KP Singh <kpsingh@kernel.org> > > Cc: Stanislav Fomichev <sdf@google.com> > > Cc: Hao Luo <haoluo@google.com> > > Cc: Jiri Olsa <jolsa@kernel.org> > > Cc: bpf@vger.kernel.org > > Fixes: 41bdc4b40ed6f ("bpf: introduce bpf subcommand BPF_TASK_FD_QUERY") > > Signed-off-by: Lee Jones <lee@kernel.org> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks.
-- Lee Jones [李琼斯]
| |