lkml.org 
[lkml]   [2022]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Documentation: stable: Document alternative for referring upstream commit hash
    Hi Jonathan,

    On Tue, Aug 09, 2022 at 06:54:59AM -0600, Jonathan Corbet wrote:
    > Salvatore Bonaccorso <carnil@debian.org> writes:
    >
    > > Additionally to the "commit <sha1> upstream." variant, "[ Upstream
    > > commit <sha1> ]" is used as well as alternative to refer to the upstream
    > > commit hash.
    > >
    > > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
    > > ---
    > > Documentation/process/stable-kernel-rules.rst | 6 ++++++
    > > 1 file changed, 6 insertions(+)
    >
    > So this is a nit but...
    >
    > > diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst
    > > index c61865e91f52..2fd8aa593a28 100644
    > > --- a/Documentation/process/stable-kernel-rules.rst
    > > +++ b/Documentation/process/stable-kernel-rules.rst
    > > @@ -97,6 +97,12 @@ text, like this:
    > >
    > > commit <sha1> upstream.
    > >
    > > +or alternatively:
    > > +
    > > +.. code-block:: none
    > > +
    > > + [ Upstream commit <sha1> ]
    >
    > Can this just be:
    >
    > or alternatively::
    >
    > [ Upstream commit <sha1> ]
    >
    > That extra RST markup just clutters things without any advantage.

    Okay, I just have sent a v2 dropping it.

    Salvatore

    \
     
     \ /
      Last update: 2022-08-09 15:38    [W:4.491 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site