Messages in this thread | | | Subject | Re: [PATCH 2/3] ASoC: apple: mca: Start new platform driver | From | Martin Povišer <> | Date | Tue, 9 Aug 2022 10:54:27 +0200 |
| |
> On 9. 8. 2022, at 10:47, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/08/2022 01:41, Martin Povišer wrote:
>> + mca->switch_base = >> + devm_platform_ioremap_resource_byname(pdev, "switch"); >> + if (IS_ERR(mca->switch_base)) >> + return PTR_ERR(mca->switch_base); > > How does it work exactly? There is no such property... Can you submit > also DTS using the bindings so we can validate they are real/correct?
Ah, I thought I fixed that. There’s supposed to be
mca->switch_base = devm_platform_ioremap_resource(pdev, 1);
of course. My bad, I guess didn’t reexport the patches after these last minute changes.
>> + >> + mca->rstc = devm_reset_control_get_shared(&pdev->dev, NULL); >> + if (IS_ERR(mca->rstc)) { >> + dev_dbg(&pdev->dev, "couldn't obtain reset control: %pe\n", mca->rstc); >> + mca->rstc = NULL; >> + } > > Similar question.
Same as above, there’s supposed to be
resets: maxItems: 1
in the schema.
> Best regards, > Krzysztof >
Martin
| |